-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
Portainer switch terminology to API token #152958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portainer switch terminology to API token #152958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Portainer integration to use the standard CONF_API_TOKEN
constant instead of CONF_API_KEY
, aligning with Home Assistant's consistent terminology for API authentication tokens.
Key Changes
- Updated all references from
CONF_API_KEY
toCONF_API_TOKEN
across configuration flow, setup, and test files - Modified user-facing strings to use "Access token" terminology instead of "API key"
- Updated configuration descriptions to reflect the new terminology
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
homeassistant/components/portainer/__init__.py |
Updated import and configuration data access to use CONF_API_TOKEN |
homeassistant/components/portainer/config_flow.py |
Updated schema definition, validation, and unique ID handling to use CONF_API_TOKEN |
homeassistant/components/portainer/strings.json |
Changed user-facing strings from "API key" to "Access token" terminology |
tests/components/portainer/conftest.py |
Updated test configuration to use CONF_API_TOKEN |
tests/components/portainer/test_config_flow.py |
Updated test imports and mock data to use CONF_API_TOKEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break beta. We need migrations for this one.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Good one, @frenck! Patched and including full test coverage. All set. :) |
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Co-authored-by: Norbert Rittel <norbert@rittel.de>
Thanks @NoRi2909! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @erwindouna 👍
../Frenck
@frenck I've solved a merge conflict. Should be ready to be merged now. :) |
Breaking change
Proposed change
Keep the terminology of Portainer to be Access token, instead of API key.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: