Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing elemIndexEnd, findIndexEnd and unzip #342

Merged
merged 3 commits into from
Jan 10, 2021
Merged

Add missing elemIndexEnd, findIndexEnd and unzip #342

merged 3 commits into from
Jan 10, 2021

Conversation

Bodigrim
Copy link
Contributor
@Bodigrim Bodigrim commented Jan 9, 2021

Resolves #104. Supersedes #294.

@Bodigrim Bodigrim requested a review from sjakobi January 9, 2021 17:49
sjakobi
sjakobi approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member
@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) Just a minor issue with the docs.

Data/ByteString/Lazy/Char8.hs Outdated Show resolved Hide resolved
@Bodigrim Bodigrim added this to the 0.11.1.0 milestone Jan 10, 2021
@Bodigrim Bodigrim mentioned this pull request Jan 10, 2021
Closed
@Bodigrim Bodigrim merged commit fe55b9b into haskell:master Jan 10, 2021
@Bodigrim Bodigrim deleted the elemIndexEnd-and-unzip branch January 10, 2021 02:55
Bodigrim added a commit to Bodigrim/bytestring that referenced this pull request Jan 11, 2021
@Bodigrim
Add missing elemIndexEnd, findIndexEnd and unzip (haskell#342)
24f080e 
* Add missing elemIndexEnd and findIndexEnd

* Add missing unzip

* Change haddock for elemIndexEnd
noughtmare pushed a commit to noughtmare/bytestring that referenced this pull request Dec 12, 2021
@Bodigrim @noughtmare
Add missing elemIndexEnd, findIndexEnd and unzip (haskell#342)
2b6ab77 
* Add missing elemIndexEnd and findIndexEnd

* Add missing unzip

* Change haddock for elemIndexEnd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1.0
Development

Successfully merging this pull request may close these issues.

Add elemIndexEnd, findIndexEnd and unzip to Data.ByteString.Lazy.Char8
2 participants
@Bodigrim @sjakobi