Fix: Use journal instead of j on MongoClient for MongoTrials #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might also close #845. This PR is more of a replacement for it. |
vad0
approved these changes
Nov 22, 2022
|
Could you please merge this fix? |
|
I can't merge this since I am not a code owner. I ended up using optuna, which does all the same stuff and even more, and which is kept up to date. https://github.com/optuna/optuna |
|
I understand, thanks for the tip, will check it out! |
lu-wang-dl
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #836
Hello! First PR around here!
I updated the
jkey tojournal, and also updated the requirements forpymongoto be at least4.0.0I don't know if I need to make any other changes on this PR such as version increases. I'll let that decision to the maintainers.