Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Agent: Add support for adding a local file attachment #2809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pglombardo
Copy link
@pglombardo pglombardo commented Jun 1, 2020

This PR adds the ability to attach a file to the outgoing email.

Huginn Email Attachment Example 2020-06-01 at 10 46 41 PM

Fixes #2449

@dsander
Copy link
Collaborator
dsander commented Jun 9, 2020

Hi! What is your use case for this? I don't completly understand when one would want one static image attached to every email. What do you think about adapting the change to consume what we call a "file pointer". There are already a few Agents that can emit such a pointer. One example is the LocalFileAgent

@pglombardo
Copy link
Author

I like the idea of the LocalFileAgent but it isn't that useful for the intended use cases.

One use case is invoice generation: ShellCommandAgent that generates a local PDF invoice file that leads to the email agent being able to attach the invoice to be sent to the customer.

Regardless agent scenario, not being able to attach files to outgoing emails is a blocker in all cases.

I'd be interested in hearing your thoughts. I started the move off of Freshbooks specifically for this feature. Unfortunately in the last mile, I find that Huginn doesn't support email attachments... which is a glaring feature hole IMO - hence the PR. :-)

@dsander
Copy link
Collaborator
dsander commented Jun 18, 2020

I like the general idea, my main concern is that the approach of only supporting files from local storage might be too limited, I might be missing something but I believe you should be able to pass the path to the file your ShellCommandAgent generated to a LocalFileAgent (which then emits a "file pointer" and then have the EmailAgent consume that pointer. The main benefit of that approach would be that the EmailAgent could use attachments from all Agents that can emit file pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create .txt file and send it as attachement.
2 participants