feat!: app.request
#1176
Merged
feat!: app.request
#1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying h3dev with
|
| Latest commit: |
1344e7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://117d2cd8.h3dev.pages.dev |
| Branch Preview URL: | https://feat-app-req.h3dev.pages.dev |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
yes i think it should be |
|
Wrappers can easily use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #1096 with
app.fetch(req)becoming more restricted, it makes sense we makeapp.request(req, init, ctx)a public API to unblock DX limits.Other API change: Types are now
Response | Promise<Response>to reduce unnecessary wrappings. (please comment if anyone feels this is a bad DX)