-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Adding links to docs.gruntwork.io
from /terragrunt-scale
page
#4938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Adding links to docs.gruntwork.io
from /terragrunt-scale
page
#4938
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Totally agreed that users need more info. My concern is that we're sending them on a bit of a disjointed journey. They start start at Terragrunt, discover TG Scale, click on Pipelines to get more info and go to Gruntwork.io...and then go back to TG Scale to purchase? I've been discussing with Tin and I think we're actually best off having TG Scale content on both Gruntwork.io and the Terragrunt website, with a singular docs site they both link to. For the TG Scale updates, I recommend:
|
{title} | ||
</a> | ||
) : ( | ||
title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be {title}
?
{title} | ||
</a> | ||
) : ( | ||
title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be {title} ?
src={Grunty2} | ||
/> | ||
</div> | ||
<a href="https://www.gruntwork.io/platform/pipelines" target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this probably shouldn't wrap the background image, just the Pipelines icon
<p class="text-sm text-[var(--color-gray-1)] m-0">Keep your IaC up-to-date</p> | ||
</div> | ||
</ColFeature> | ||
<a href="https://www.gruntwork.io/platform/patcher" target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same feedback here - I don't think this should wrap the Grunty, only the patcher icon
Description
Fixes #000.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide