Debug or Trace logging for get_aws_account_id() #4751
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
config/locals.go
Outdated
| errs := &errors.MultiError{} | ||
|
|
||
| for _, attr := range attrs { | ||
| l.Debugf("TRACE: evaluating local %q...", attr.Name) |
There was a problem hiding this comment.
Instead of the "trace" prefix, it might be better to use a trace-level message?
|
|
||
| // Return the AWS account id associated to the current set of credentials | ||
| func getAWSAccountID(ctx *ParsingContext, l log.Logger) (string, error) { | ||
|
|
There was a problem hiding this comment.
The ticket also mentioned adding extra logs to this function
There was a problem hiding this comment.
you mean like this
l.Debugf("TRACE: invoking get_aws_account_id()...")
There was a problem hiding this comment.
@wakeful have a look ??
Description
Fixes #4389
Add DEBUG or TRACE in getAWSAccountID function and attemptEvaluateLocals to get better context.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide