runtime: use timer_settime64 on 32-bit Linux #75957

abdullahkiani007 · 2025-10-17T17:13:27Z

Linux introduced new syscalls to fix the year 2038 issue.
To still be able to use the old ones, the Kconfig option
COMPAT_32BIT_TIME would be necessary.

Use the new 64-bit syscall for timer_settime by default.
Add a fallback to use the 32-bit syscall when the
64-bit version returns _ENOSYS.

Fixes #75133

gopherbot · 2025-10-17T17:20:26Z

This PR (HEAD: 03e376f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/712642.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-17T17:28:29Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T17:28:29Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T17:54:03Z

Message from Jorropo:

Patch Set 1: Commit-Queue+1

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T18:02:19Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-17T17:46:15Z","revision":"dc7b90aba50b76568fffa3e0c42376dd48d2a549"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T18:10:30Z

Message from Jorropo:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T18:10:30Z

Message from Jorropo:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T18:10:31Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386-sizespecializedmalloc has failed with summary (view all results):

go on master (change 712642)

To reproduce, try gomote repro 8700741644857485345.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T18:10:31Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T18:18:43Z

Message from Jorropo:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T18:18:44Z

Message from Jorropo:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T21:18:42Z

Message from Abdullah:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-17T22:27:17Z

This PR (HEAD: 505602b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/712642.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-18T00:21:59Z

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T03:39:42Z

Message from Jorropo:

Patch Set 4:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T03:39:43Z

Message from Jorropo:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T03:47:15Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-18T03:31:48Z","revision":"dd4d3319cdc60e9680bee88499abf2915c81df04"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T03:47:16Z

Message from Jorropo:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T03:54:46Z

Message from Jorropo:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T03:54:46Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Re 8000 ason:

Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):

go on master (change 712642)

To reproduce, try gomote repro 8700704794390172609.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T03:54:47Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T10:02:22Z

This PR (HEAD: 6dd3442) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/712642.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-18T13:28:03Z

Message from Abdullah:

Patch Set 5:

(14 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T13:53:20Z

Message from Jorropo:

Patch Set 5: Code-Review+2 Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T13:53:21Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-18T13:35:56Z","revision":"c8409e30279c4c26bdbf9c00ee71358a5bda6de9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T14:01:19Z

Message from Jorropo:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T14:01: 7FA 19Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-misccompile has failed with summary (view all results):

go on master (change 712642)

Error: shard 1: failed to run compile goos:"linux" goarch:"arm" port: exit status 2

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

103CE

gopherbot · 2025-10-18T14:01:20Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T14:36:09Z

This PR (HEAD: 5f3e8c5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/712642.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Linux introduced new syscalls to fix the year 2038 issue. To still be able to use the old ones, the Kconfig option COMPAT_32BIT_TIME would be necessary. Use the new 64-bit syscall for timer_settime by default. Add a fallback to use the 32-bit syscall when 64-bit version returns _ENOSYS. Fixes golang#75133

gopherbot · 2025-10-18T14:43:59Z

This PR (HEAD: 6c3d62d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/712642.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-18T14:59:09Z

Message from Abdullah:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T16:19:47Z

Message from Jorropo:

Patch Set 7: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T16:19:48Z

7F2

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-18T16:06:59Z","revision":"2403c4b1527ac71b8fb773b0cf37278c0a8f21ef"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T16:35:11Z

Message from Jorropo:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T16:35:12Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T16:35:12Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-18T16:50:27Z

Message from Jorropo:

Patch Set 7: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712642.
After addressing review feedback, remember to publish your drafts!

austinderek mentioned this pull request Oct 17, 2025

runtime: handle timer_settime32 fallback on 32-bit Linux PullRequestInc/go#112

Open

abdullahkiani007 changed the title ~~runtime: handle timer_settime32 fallback on 32-bit Linux~~ runtime: use timer_settime64 on 32-bit Linux Oct 17, 2025

abdullahkiani007 force-pushed the dev.fix_syscall_timer-settime32 branch from 03e376f to 505602b Compare October 17, 2025 22:22

abdullahkiani007 force-pushed the dev.fix_syscall_timer-settime32 branch from 505602b to 6dd3442 Compare October 18, 2025 10:00

abdullahkiani007 force-pushed the dev.fix_syscall_timer-settime32 branch from 6dd3442 to 5f3e8c5 Compare October 18, 2025 14:33

abdullahkiani007 force-pushed the dev.fix_syscall_timer-settime32 branch from 5f3e8c5 to 6c3d62d Compare October 18, 2025 14:40

runtime: use timer_settime64 on 32-bit Linux #75957

Are you sure you want to change the base?

runtime: use timer_settime64 on 32-bit Linux #75957

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants