feat: Add support for private registries endpoints #3785
+851
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
acouvreur
commented
Oct 22, 2025
gmlewis
requested changes
Oct 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3785 +/- ##
==========================================
+ Coverage 91.50% 91.54% +0.04%
==========================================
Files 190 191 +1
Lines 17007 17088 +81
==========================================
+ Hits 15562 15643 +81
Misses 1257 1257
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
Thank you, @acouvreur!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
alexandear
suggested changes
Oct 22, 2025
github/private_registries.go
Outdated
Comment on lines
61
to
62
| TotalCount *int `json:"total_count,omitempty"` | ||
| Configurations []*PrivateRegistry `json:"configurations,omitempty"` |
There was a problem hiding this comment.
Suggested change
| TotalCount *int `json:"total_count,omitempty"` | |
| Configurations []*PrivateRegistry `json:"configurations,omitempty"` | |
| TotalCount int `json:"total_count"` | |
| Configurations []*PrivateRegistry `json:"configurations"` |
total_count and configurations are required according to the schema:
{
"type": "object",
"required": [
"total_count",
"configurations"
],
"properties": {
"total_count": {
"type": "integer"
},
"configurations": {
"type": "array",
"items": {
"title": "Organization private registry",
"description": "Private registry configuration for an organization",
"type": "object",
"properties": {
"name": {
"description": "The name of the private registry configuration.",
"type": "string",
"examples": [
"MAVEN_REPOSITORY_SECRET"
]
},
"registry_type": {
"description": "The registry type.",
"enum": [
"maven_repository",
"nuget_feed",
"goproxy_server",
"npm_registry",
"rubygems_server",
"cargo_registry",
"composer_repository",
"docker_registry",
"git_source",
"helm_registry",
"hex_organization",
"hex_repository",
"pub_repository",
"python_index",
"terraform_registry"
],
"type": "string"
},
"username": {
"description": "The username to use when authenticating with the private registry.",
"type": [
"string",
"null"
],
"examples": [
"monalisa"
]
},
"visibility": {
"description": "Which type of organization repositories have access to the private registry.",
"enum": [
"all",
"private",
"selected"
],
"type": "string"
},
"created_at": {
"type": "string",
"format": "date-time"
},
"updated_at": {
"type": "string",
"format": "date-time"
}
},
"required": [
"name",
"registry_type",
"visibility",
"created_at",
"updated_at"
]
}
}
}
}
github/private_registries.go
Outdated
Comment on lines
51
to
56
| Name *string `json:"name,omitempty"` | ||
| RegistryType *string `json:"registry_type,omitempty"` | ||
| Username *string `json:"username,omitempty"` | ||
| CreatedAt *Timestamp `json:"created_at,omitempty"` | ||
| UpdatedAt *Timestamp `json:"updated_at,omitempty"` | ||
| Visibility *string `json:"visibility,omitempty"` |
There was a problem hiding this comment.
Suggested change
| Name *string `json:"name,omitempty"` | |
| RegistryType *string `json:"registry_type,omitempty"` | |
| Username *string `json:"username,omitempty"` | |
| CreatedAt *Timestamp `json:"created_at,omitempty"` | |
| UpdatedAt *Timestamp `json:"updated_at,omitempty"` | |
| Visibility *string `json:"visibility,omitempty"` | |
| Name string `json:"name"` | |
| RegistryType string `json:"registry_type"` | |
| Username *string `json:"username,omitempty"` | |
| CreatedAt Timestamp `json:"created_at"` | |
| UpdatedAt Timestamp `json:"updated_at"` | |
| Visibility string `json:"visibility"` |
name, registry_type, visibility, created_at, updated_at are required according to the schema
There was a problem hiding this comment.
I considered all response struct members as pointers to avoid issues if something changed on the API side while using this version of the library.
Should I follow instead the schema and avoid marking all response struct members as optional ?
<
8000
div class="AvatarStack flex-self-start " >
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
2E78
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for private registries endpoints.
See https://docs.github.com/rest/private-registries for more details.
script/generate.sh,script/fmt.shandscript/lint.shhave been run without issue.Closes #3784