-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: React 18 markers #1224
base: master
Are you sure you want to change the base?
Fix: React 18 markers #1224
Conversation
+1 👍 for this |
@itsmichaeldiego This really needs to be merged. Otherwise, this library will naturally die. |
+1 for this to be merged |
+1 to merge this... |
+1 |
1 similar comment
+1 |
3d911dc
to
69f2e14
Compare
To avoid this warning: I've moved |
Any update on when this is going to get merged? @karldanninger @itsmichaeldiego |
It won't be. The library is abandoned. Is this PR available in a fork anywhere? |
Is this project still alive? This pull request will fix a very bad bug, please marge it |
I've created a fork that contains this branch's changes:
|
If you need this now and can't wait for the merge, you can create a patch and apply it to your local project. 1. Clone the repository
2. Download the PR as a Patch File Open the pull request URL and add Original PR URL: Save the patch file ( 3. Apply the Patch Inside your local copy of
4. Commit Your Changes Add and commit your changes:
5. Create a Tarball from Your Package Create a tarball of your patched package:
This will generate a file like 6. Use the Tarball in Your Project Copy the tarball file (
7. Install the Package
After applying this, everything works again, I see all markers and the markers don't flicker or jump around when I move the map. Thank you @BenHodgsonR2R and maybe @karldanninger or @itsmichaeldiego can look into this too. Thanks |
Any updates on merging this? |
My recommendation is to either:
I don't think it's worth relying on contributions here. The project I've been working on that previously used this library has been migrated to https://github.com/visgl/react-google-maps and we haven't faced any issues with React 18. |
Issue: (#1223)
This pull request addresses an issue with the markers rendering incorrectly using React
^18
.The issues were:
dimensionsCache
property incomponentWillUnmount
.https://react.dev/blog/2022/03/29/react-v18#new-strict-mode-behaviors
flushSync
).https://react.dev/blog/2022/03/29/react-v18#new-feature-automatic-batching