add ghttp server start hooks #4474
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds server lifecycle hooks to the ghttp server, allowing developers to register callback functions that execute at specific points during server startup. The implementation provides both "before start" hooks for initialization tasks that can prevent server startup if they fail, and "after start" hooks for post-startup tasks that are executed after the server is successfully running.
Key changes:
- Added
SetBeforeStart()andSetAfterStart()methods to register lifecycle hooks - Integrated hook execution into the server startup process with proper error handling
- Added comprehensive test coverage for various hook scenarios including error handling and execution order
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
net/ghttp/ghttp.go |
Added ServerHookFunc type and hook storage fields to the Server struct |
net/ghttp/ghttp_server_lifecycle_hooks.go |
Implemented the lifecycle hook methods and execution logic |
net/ghttp/ghttp_server.go |
Integrated hook execution into the server startup process |
net/ghttp/ghttp_z_unit_feature_lifecycle_hooks_test.go |
Added comprehensive unit tests for lifecycle hook functionality |
net/ghttp/example_lifecycle_hooks_test.go |
Added example code demonstrating hook usage patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
add ghttp server start hooks