Add chromedp backend #844
Open
Add chromedp backend #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but more testing required. |
|
Is there any update on this? are we planning to merge this |
|
I'd like to merge it if we receive 1-2 positive feedbacks that it is stable and works as excepcted. |
|
I think in the latest rebase it broke, it hangs someplace. I don't currently have capacity to work on it at the moment. Anyone else is free to work on top of this until I can get to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased this but haven't checked it too thoroughly.
This adds a HTTPDriver interface and implements chromedp as one of the implementations.