Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gnovm): add software floating point package #2863

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(gnovm): add software floating point package #2863

wants to merge 2 commits into from
+930 −0

Conversation

thehowl
Copy link
Member
@thehowl thehowl commented Sep 27, 2024 •
edited
Loading

Based on the runtime softfloat64.go file.

Fixes #312 .

Still WIP, need to include it into the source code for the GnoVM.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this Sep 27, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 27, 2024
@codecov Codecov
Copy link
codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.30310% with 137 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (1e27785) to head (aa07dce).
Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
.../gnolang/internal/softfloat/runtime_softfloat64.go 70.72% 108 Missing and 5 partials ⚠️
gnovm/pkg/gnolang/internal/softfloat/softfloat.go 27.27% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2863      +/-   ##
==========================================
+ Coverage   60.91%   60.94%   +0.03%     
==========================================
  Files         564      566       +2     
  Lines       75273    75692     +419     
==========================================
+ Hits        45856    46134     +278     
- Misses      26046    26183     +137     
- Partials     3371     3375       +4
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 67.17% <ø> (ø)
gnovm 65.80% <67.30%> (+0.02%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl mentioned this pull request Oct 5, 2024
Open
@thehowl thehowl added this to the 🚀 Mainnet launch milestone Nov 6, 2024
@thehowl thehowl added the in focus Core team is prioritizing this work label Nov 6, 2024
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zxxma zxxma

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
💪 Bounties & Worx
Status: No status
🧙‍♂️gno.land core team
Status: Todo
Milestone
🚀 Mainnet launch
Development

Successfully merging this pull request may close these issues.

Test and document floating point determinsm
3 participants
@thehowl @Kouteki @zxxma