Add support for rem values in gap and peek
#599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @jedrzejchalubek, do you have some time to review/merge this? |
| * @param {Glide} glide | ||
| * @returns {Number} | ||
| */ | ||
| export function toPx (value) { |
There was a problem hiding this comment.
I think this logic here can be simplified following way:
export function toPx (value) {
if (value.endsWith('rem')) {
const { fontSize } = window.getComputedStyle(document.documentElement)
return toInt(int * toFloat(fontSize))
}
return toInt(value)
}There was a problem hiding this comment.
Other than that looks LGTM :)
There was a problem hiding this comment.
@jedrzejchalubek Sorry for getting back so late! This would unfortunately cause an error whenever value is not a string, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of relative sizes with
reminpeekandgapinstead of just pixel units.