Adding default toolset as configuration #1229
Merged
+390
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…rver into tonytrg/add-default
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a special "default" toolset configuration to simplify workflow setup when working with default and additional toolsets. Instead of requiring users to copy and recreate the default toolset and add specific toolsets, they can now use the default keyword to quickly reference the standard configuration.
- Adds a special
defaulttoolset keyword that expands to the standard toolset configuration - Implements
cleanToolsetsfunction to handle toolset processing logic including deduplication and special keyword expansion - Updates CLI help documentation to explain the new special toolset keywords and provide usage examples
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Adds metadata for special toolsets and updates help text generation |
| internal/ghmcp/server.go | Implements cleanToolsets function and integrates it into server initialization |
| internal/ghmcp/server_test.go | Comprehensive test suite for the cleanToolsets function |
| cmd/github-mcp-server/main.go | Updates default toolset initialization to use the new default keyword |
| README.md | Updates documentation to explain special toolsets and usage patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
omgitsads
previously approved these changes
Oct 15, 2025
omgitsads
approved these changes
Oct 15, 2025
|
Stop all approval request |
|
pohi99999
added a commit
to pohi99999/github-mcp-server
that referenced
this pull request
Oct 19, 2025
* 'main' of https://github.com/github/github-mcp-server: Add Gemini CLI extension (github#1232) Adding default toolset as configuration (github#1229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As we now introduce default toolsets, we want to enable the workflow to quickly add specific toolsets to the current experience.
Right now this requires copying and recreating the default toolset and adding the specific toolsets.
To make it easier to configure we allow the additional special toolset
default.Changes
defaulttoolsetCloses: