Enum to varchar #963
Enum to varchar #963
Conversation
Actions/Workflow: upload artifact
Support a complete ALTER TABLE statement in --alter
handle driver timeout error
Updates from upstream 2020 10
Initial commit: towards setting up a test suite Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copying AUTO_INCREMENT value to ghost table
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Generated column as part of UNIQUE (or PRIMARY) KEY
Cut-over should wait for heartbeat lag to be low enough to succeed
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
All MySQL DBs limited to max 3 concurrent/idle connections
…context Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
hooks: reporting GH_OST_ETA_SECONDS. ETA as part of migration context
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
@shlomi-noach any concerns if I re-open this PR? I think this includes some PRs we haven't merged but this would be useful to have in this repo |
|
@timvaillancourt let me open a new one, since there's been more commits to this branch than are present here. |
|
@shlomi-noach oh, thanks a lot! We can handle getting this PR in-sync if you'd like, I think we'll just need to merge a few dependant PRs to get this one mergeable. Totally up to you, thanks! |
|
@timvaillancourt I see some merge conflicts locally, looks like I need to pull from upstream. Will do so tomorrow morning! |
|
@timvaillancourt well that was short. The PR is all yours! |
|
@shlomi-noach thanks a lot! This support will unblock some |
I hope you mean |
@shlomi-noach I think the blocked migrations are I believe we would have numbers instead of real |
|
ahh, got it. |
|
branch updated after recent merge of downstream contribution. |
|
This PR passed integration testing 100%, merging. Thanks @shlomi-noach! |
Related issue: #642
Description
Looking into
-alterconverting anenumintovarchar. Per #642 this copies the numeric value of the enum into the varchar column, where we want the textual value.Initial commit: test suite to confirm error.