limits tags just on commit, show tags on commits page. close #1968 #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kounoike I agree with showing tags on the commits list, but don't agree with limiting tags in the commit page quickly. I can merge first one immediately if you split this pull request into two pull requests. |
|
@takezoe How about changes like this (edit by dev-mode) screenshot? (tags are already expanded by click) I think these changes are important
But it requires more discussion. So I will make new PR which contains only commits list page changes. |
kounoike
added a commit
to kounoike/gitbucket
that referenced
this pull request
Apr 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is answer for #1968. It limits tags on commit.
And this PR also provide tag list on commit history page.
Before submitting a pull-request to GitBucket I have first: