Add a show-download setting that defaults to all #3595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffbaumes You have to restart girder if you change this setting to see it take effect. You can use the usual techniques: add it to the setting in the provisioning file, use an environment variable, or hit the settings endpoint: |
|
Also, I have a branch that would merge into girder master if we want to avoid feature separation (but it would also then need to be pushed into the v4 integration branch). |
a560ec7 to
13838ed
Compare
This setting is core.download_shown and can be "all" (default), "user", "admin", or "none". If not all, download controls are only shown for a subset of users -- any logged in user, only those who are admins, or no one. This doesn't effect endpoints, just what is shown in the UI.
13838ed to
b4eb5cd
Compare
jeffbaumes
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is core.download_shown and can be "all" (default), "user", "admin", or "none". If not all, download controls are only shown for a subset of users -- any logged in user, only those who are admins, or no one.
This doesn't effect endpoints, just what is shown in the UI.