Improve uploads #3545
Open
Improve uploads #3545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'_id' may not exist in upload if it has not been saved.
821d01d to
b0415d0
Compare
zachmullen
approved these changes
Jun 24, 2024
zachmullen
requested changes
Jun 24, 2024
A FileHandle may be closed before destruction. Call seek() to reopen the file.
On slow assetstore, call mkdir each time a file is accessed is too slow.
zachmullen
reviewed
Jul 1, 2024
| pass | ||
| finally: | ||
| if not unavailable: | ||
| FilesystemAssetstoreAdapter.initialized = True |
@finetjul Rather than adding this logic, I think we should just move the mkdir call to only be where it's actually needed. Additionally, we can make tempDir a property of the class, and thereby remove this __init__ method altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.