Fix: Prevent infinite recursion in form mapping with self-referencing pointers #4337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Infinite Recursion in Form Mapping with Self-Referencing Pointers
Problem
Stack overflow crash occurs when binding query parameters to structs containing self-referencing pointers (e.g.,
Parent *Req
) when no query values are provided.Root Cause
The
mapping
function in/binding/form_mapping.go:96
would infinitely create new instances when processing self-referencing struct pointers without termination conditions.Solution
Implemented a depth limiting mechanism to prevent infinite recursion:
maxMappingDepth = 10
constant for recursion depth controlmappingWithDepth
function with depth parameter trackingFiles Changed
binding/form_mapping.go
: Added depth limiting logicbinding/form_mapping_test.go
: Added comprehensive test coverageTest Results
Fixes #3791