Coverage remained the same at 100.0% when pulling 6995dbb on enjoy-binbin:connect-hang into ace80f4 on fluent:master.

Coverage decreased (-1.07%) to 98.928% when pulling bb8efb8 on enjoy-binbin:connect-hang into ace80f4 on fluent:master.

I'll review it at depth when I have time, but I'm inclined not to accept this change.

Unless I'm missing something the error should lead to a reconnect and resending of the logs. Clearing the queue will cause the loss of perfectly good logs due to a simple reconnect issue, which would not be acceptable.

Yep Not problem. I understand it is risky

Or maybe we should just print some logs to help the user for debug

We can consider a tunable setting which would "discard logs on reconnect" and defaults to False. Reconnects are a part of life and discarding logs isn't useful in most cases IMO.

I tend to make decisions against arbitrary loss of data.

Right. I can give a try. Thanks @arcivanov

@arcivanov
I add a discard_logs_on_reconnect_error setting default false. Maybe not good enough