Permit multiple Webview instances #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first call to `objc_allocateClassPair` for a given name will succeed; subsequent calls return `nil` (`nullptr`), resulting in a segfault. This is a low tech approach to getting around this restriction; there are undoubtedly more 'proper' ways of going about this but it works.
|
Hello |
|
I've updated the webview component, and now it seems to have logic which would prevent the issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like
fltk-rsand I'm hoping to be able to use it more. The one thing I ran into was creating multiple webview instances.Only the first call to
objc_allocateClassPairfor a given name will succeed; subsequent calls returnnil(nullptr), resulting in a segfault.This is a low tech approach to getting around this restriction; there are undoubtedly more 'proper' ways of going about this but it works.
This change in its current form may or may not be acceptable to you; I'm using it locally and it works but you may have a preferred way of unblocking the same functionality. Either way, I'd be happy to help get the change in.
All the best
Tosh