Support absolute memory counters #5216
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support absolute in addition to relative memory counters and render them correctly. This involves incrementing the profiler versions.
|
This pull request is a draft. I still have to:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5216 +/- ##
==========================================
- Coverage 88.62% 88.57% -0.05%
==========================================
Files 308 308
Lines 28059 28104 +45
Branches 7598 7625 +27
==========================================
+ Hits 24867 24894 +27
- Misses 2978 2995 +17
- Partials 214 215 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support absolute in addition to relative memory counters and render them correctly. This involves incrementing the profiler versions.
The corresponding gecko code change is 1806054 (https://bugzilla.mozilla.org/show_bug.cgi?id=1806054): Memory profiling uses the expensive malloc_usable_size function.