Update libffi to v3.4.8 #1145
Merged
Update libffi to v3.4.8 #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larskanis Did you want to pick 4aac33b or merge #1119 outright to fix the |
|
Homebrew has already updated to llibffi v3.4.8, so I'm going to pick 4aac33b here to see if we can get a green build. |
|
It seems that the libffi v3.4.7 is still being used in https://github.com/ffi/ffi/actions/runs/14385895065/job/40341120111?pr=1145. https://formulae.brew.sh/formula/libffi shows that libffi has been updated to v3.4.8, so perhaps it's just a matter of time. |
|
My Homebrew install seems to have picked up v3.4.8, so perhaps the CI machines are using some other cached version: |
|
ruby-head is failing, likely due to the change in ruby/ruby@d80f3a2. |
|
The other failures need #1119. Perhaps that should be merged first then. |
This updates to the latest tagged version.
...since it will not be shipped with Ruby after Ruby 3.5.0. For now, JRuby & TruffleRuby fail on this, so we use a platforms directive. ffi#1119 (review)
77089ff to
fc065ad
Compare
This ensures the latest version of libffi is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the latest tagged version.