-
Notifications
You must be signed in to change notification settings - Fork 337
Update to libffi v3.4.7 + patch #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes a compilation issue with clang 17 and macOS: libffi/libffi#857 Details: https://github.com/libffi/libffi/releases/tag/v3.4.7
In https://github.com/ffi/ffi/actions/runs/14237177527/job/39910781515?pr=1144, I see CI failing:
libffi/libffi#210 suggests |
This is needed for libffi and autoconf: libffi/libffi#210
5700a47
to
b98ee47
Compare
I'm seeing two main types of errors now:
|
I reproduced this on a macOS 13 system. It seems that libffi/libffi#848 is the culprit. libffi/libffi#889 fixes this. Updating |
This pulls in libffi/libffi#889, which fixes test errors on macOS 13.
This update is essentially passing CI. There are some failures:
|
`centos:latest` is no more, so update the image accordingly.
Compare the results of this to the latest run on |
Thank you for helping! I'll try to push a new release the next days. |
@larskanis just a gentle poke on this. There are many ruby gems that have ffi as a dependency and this issue means they can't be installed on newer macs or on new environments, this impacts new starters & attempts to upgrade ruby locally, so the number of people impacts by this is going to go up day by day. For anyone else struggling with this, I eventually found a workaround, but it takes a tediously long time.
This should now show version 16.x.x.
|
I'm surprised you ran into issues with LLVM 16; I thought LLVM 17 had issues, though. In any case, it looks like the 1.17.2 tag was created. Now we await a push of the gem to RubyGems. I see https://github.com/ffi/ffi/actions/runs/14454729540 has built the v1.17.2 tag. |
I have no problems with LLVM 16. I have problems with clang 17 (which I believe most modern apple products will now be using) so I had to manually install LLVM 16 (as per the described steps) in order to get clang 16 to install locally, and then use that to install the gem. |
This fixes a compilation issue with clang 17 and macOS: libffi/libffi#857
Details: https://github.com/libffi/libffi/releases/tag/v3.4.7