Enqueue fallback results onto the completion queue #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2021 03:08
Summary: Change type of CompleteReq to accept a ResultVal rather than an Either. This prepares it for being used in the next diff, and should be a no-op as the transform happened before use anyway Differential Revision: D28964006 fbshipit-source-id: ce321c36620907e54c412e5e891201bad234464c
Summary: Rather enqueue fallback results onto the completion queue, to better mimic what happens in a real fetch. This allows `F <$> a <*> b` to fetch both a and b, even if a throws an exception. Reviewed By: josefs Differential Revision: D28964005 fbshipit-source-id: 88b826081d2458b78cb61385d654c8a275f79ec9
|
This pull request was exported from Phabricator. Differential Revision: D28964005 |
|
This pull request has been merged in 8f018dc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rather enqueue fallback results onto the completion queue, to better mimic what happens in a real fetch.
This allows
F <$> a <*> bto fetch both a and b, even if a throws an exception.Reviewed By: josefs
Differential Revision: D28964005