Add more Google features #1207
Open
Add more Google features #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow automatic account creation as with GitHub
- Allow limiting which Google domains can create accounts
- Add documentation of the flags involved
- Allow automatic account creation as with GitHub - Allow limiting which Google domains can create accounts - Add documentation of the flags involved
|
This shouldn't affect existing installs - so long as neither |
|
Very nice @smerrill! I know this code area is a little light on unit tests. Would you be able to add a bit of coverage? Breaking up google_oauth2 might help with that. |
1 similar comment
pquerner
reviewed
Jul 16, 2017
|
|
||
| if google_domain && !google_email.end_with?("@#{google_domain}") | ||
| # Fail if the email does not match our domain | ||
| flash[:error] = "'#{google_email}' is unauthorized. Only #{google_domain} email addresses are allowed." |
There was a problem hiding this comment.
Good point, should be minimal disclosure. @smerrill you up for fixing this?
rud
suggested changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.