Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Samples for macOS #567

Merged
merged 2 commits into from
Dec 28, 2019
Merged

Fixes for Samples for macOS #567

merged 2 commits into from
Dec 28, 2019

Conversation

thedmd
Copy link
Contributor
@thedmd thedmd commented Dec 28, 2019

PR solve two problems with samples:

  • GLSL 1.3 is not available on macOS, bumped to 1.5 (Apple platforms only)
  • To avoid problems with locating data files for Samples were build as a bundle where resource files are copied into it

@erincatto erincatto self-requested a review December 28, 2019 03:41
erincatto
erincatto approved these changes Dec 28, 2019
View reviewed changes
Copy link
Owner
@erincatto erincatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@erincatto erincatto merged commit 9330068 into erincatto:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erincatto erincatto erincatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thedmd @erincatto