-
Notifications
You must be signed in to change notification settings - Fork 984
dialect/sql/schema: versioned migrations #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very very good @masseelch! I'm super excited about it.
4d3ad1f
to
6e3dda3
Compare
…anges to migration file
…stead of a planner
f73c6c3
to
d51e870
Compare
a8m
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @masseelch! ❤️ 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to have Ent (Atlas actually) create migration files. The files itself by default follow the format understood by golang-migrate/migrate without any extra configuration. Flyway can be configured to work with them. However, the file format itself is configurable by passing in a custom
migrate.Formatter
with theWithFormatter()
builder.Versioned migrations only work, if the new migration engine based on Atlas is enabled.
There are two ways to use the new feature:
ent/migrate/main.go
which can be executed to create a new migration file. It also serves as an example of how to use the generated Client to create new files programatically.ent migrate diff
which loads the graph and calculates the diff by connection to a dev database.Documentation will follow in another PR.