Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore separator: '\n;' to vendor JS concat #7477

Merged

Conversation

kellyselden
Copy link
Member

Closes #7470

Retargeted the commit:

Prior to 2.17, Ember CLI used a semicolon to separate files concatenated into vendor.js: https://github.com/ember-cli/ember-cli/blob/v2.16.2/lib/broccoli/bundler.js#L92

Vendor shims are still generated with a leading paren:

(function() {
  function vendorModule() {
    'use strict';

    return {
      'default': self['test'],
      __esModule: true,
    };
  }

  define('test', [], vendorModule);
})();

This can cause TypeError: (intermediate value)(...) is not a function if the code immediately prior does not end in a semicolon.
.

Prior to 2.17, Ember CLI used a semicolon to separate files concatenated into vendor.js: https://github.com/ember-cli/ember-cli/blob/v2.16.2/lib/broccoli/bundler.js#L92

Vendor shims are still generated with a leading paren:
```
(function() {
  function vendorModule() {
    'use strict';

    return {
      'default': self['test'],
      __esModule: true,
    };
  }

  define('test', [], vendorModule);
})();
```

This can cause `TypeError: (intermediate value)(...) is not a function` if the code immediately prior does not end in a semicolon.
.
@Turbo87 Turbo87 added the bug label Dec 1, 2017
@Turbo87 Turbo87 merged commit c6ec51f into ember-cli:release Dec 1, 2017
@kellyselden kellyselden deleted the lenny/restore-vendor-separator branch December 1, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants