Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain node 4 in addons #7026

Merged
merged 1 commit into from
May 4, 2017
Merged

explain node 4 in addons #7026

merged 1 commit into from
May 4, 2017

Conversation

kellyselden
Copy link
Member

No description provided.

@stefanpenner
Copy link
Contributor

@homu r+

@homu
Copy link
Contributor
homu commented May 4, 2017

📌 Commit 1c1a215 has been approved by stefanpenner

@homu
Copy link
Contributor
homu commented May 4, 2017

⌛ Testing commit 1c1a215 with merge c754105...

homu added a commit that referenced this pull request May 4, 2017
@homu
Auto merge of #7026 - ember-cli:node4in-addons, r=stefanpenner
c754105 
explain node 4 in addons
@homu
Copy link
Contributor
homu commented May 4, 2017

☀️ Test successful - status

@homu homu merged commit 1c1a215 into master May 4, 2017
@kellyselden kellyselden deleted the node4in-addons branch May 5, 2017 00:39
@kellyselden kellyselden mentioned this pull request May 6, 2017
Merged
alexdiliberto added a commit to alexdiliberto/ember-open-browser that referenced this pull request Jul 26, 2017
@alexdiliberto
Configure addon to work with >= Node 4.x
58b6622 
SEE: ember-cli/ember-cli#7026

This addon will break other consuming addons which are doing all CI testing against Node v4.x - See my current build failure https://travis-ci.org/alexdiliberto/ember-cli-transformicons/jobs/257576872. This PR will address the issue.
@alexdiliberto alexdiliberto mentioned this pull request Jul 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kellyselden @stefanpenner @homu @Turbo87