-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 🐹 as "ember" alias #6928
The head ref may contain hidden characters: "\u{1F439}"
Add 🐹 as "ember" alias #6928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should help with file size
Windows still works SHIPIT |
le jit |
Improves developer happiness +1 |
@homu r+ |
📌 Commit 56daef5 has been approved by |
Add 🐹 as "ember" alias because... why not?
⚡ Test exempted - status |
Are you people kidding? This stuff can affect people using this in production badly. It's a very developer centric view on things here. Can you imagine giving headaches to people, that want to debug things? How actually should someone know, that this emoji is pointing on ember in a log file? Please remove that! This is far beyond unprofessional. |
Heaven forbid we have any fun on this volunteer run, open source project. No one has complained yet, but if it's causing people grief we can take it out. Major breaking change v3.0 to take it out? Haha |
It would be great to at least offer the ability to opt out. |
@kellyselden It's fine to have fun. I love fun. Most people do. That's not what my comment is about. It's about giving headaches to pleople seeing an emoji in their logs and trying to fix high prio issues and not knowing what to do about it. |
Like I said, this is the first we've heard of it being a problem. No malice intended. Please open an issue, or better yet, file a PR removing, so the conversation can continue. I think questioning our professionalism was the wrong approach. Locking before the conversation digresses further. |
because... why not?