Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 🐹 as "ember" alias #6928

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Add 🐹 as "ember" alias #6928

merged 1 commit into from
Apr 1, 2017

Conversation

Turbo87
Copy link
Member
@Turbo87 Turbo87 commented Mar 31, 2017

because... why not?

Copy link
Contributor
@hjdivad hjdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should help with file size

@kellyselden
Copy link
Member

Windows still works SHIPIT

@twokul
Copy link
Contributor
twokul commented Apr 1, 2017

le jit

@lukemelia
Copy link
Contributor

Improves developer happiness +1

@Turbo87
Copy link
Member Author
Turbo87 commented Apr 1, 2017

@homu r+

@homu
Copy link
Contributor
homu commented Apr 1, 2017

📌 Commit 56daef5 has been approved by Turbo87

@homu homu merged commit 56daef5 into ember-cli:beta Apr 1, 2017
homu added a commit that referenced this pull request Apr 1, 2017
Add 🐹 as "ember" alias

because... why not?
@homu
Copy link
Contributor
homu commented Apr 1, 2017

⚡ Test exempted - status

@Turbo87 Turbo87 deleted the 🐹 branch April 1, 2017 15:31
@paschelino
Copy link
paschelino commented Sep 26, 2017

Are you people kidding? This stuff can affect people using this in production badly. It's a very developer centric view on things here. Can you imagine giving headaches to people, that want to debug things? How actually should someone know, that this emoji is pointing on ember in a log file? Please remove that! This is far beyond unprofessional.

@kellyselden
Copy link
Member

Heaven forbid we have any fun on this volunteer run, open source project. No one has complained yet, but if it's causing people grief we can take it out.

Major breaking change v3.0 to take it out? Haha

@KernelPanicAUS
Copy link

It would be great to at least offer the ability to opt out.
Not everyone is fond of having emojis as executables on their path and there's nothing wrong with that.

@paschelino
Copy link

@kellyselden It's fine to have fun. I love fun. Most people do. That's not what my comment is about. It's about giving headaches to pleople seeing an emoji in their logs and trying to fix high prio issues and not knowing what to do about it.

@kellyselden
Copy link
Member

Like I said, this is the first we've heard of it being a problem. No malice intended. Please open an issue, or better yet, file a PR removing, so the conversation can continue.

I think questioning our professionalism was the wrong approach. Locking before the conversation digresses further.

@ember-cli ember-cli locked and limited conversation to collaborators Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants