-
Notifications
You must be signed in to change notification settings - Fork 62
FuSa evaluation draft of gtest #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FuSa evaluation draft of gtest #1907
Conversation
Added drawio diagram Updated evaluation
|
The created documentation from the pull request is available at: docu-html |
- added comment in requirements section - updated diagram - removed compiler examples
docs/score_tools/gtest.rst
Outdated
GoogleTest (gtest) is a C++ testing framework developed by Google to support the creation | ||
of robust, maintainable, and portable tests. It is designed to help developers write tests | ||
by offering a rich set of assertions, test fixtures, and test discovery | ||
mechanisms. gtest supports compatible with various platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google refers to it as GTest
. Please replace across whole document.
See https://github.com/google/googletest?tab=readme-ov-file#related-open-source-projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in whole document.
docs/score_tools/gtest.rst
Outdated
GoogleTest (gtest) is a C++ testing framework developed by Google to support the creation | ||
of robust, maintainable, and portable tests. It is designed to help developers write tests | ||
by offering a rich set of assertions, test fixtures, and test discovery | ||
mechanisms. gtest supports compatible with various platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supports compilation?
is compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is compatible.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix GTest
also on a diagram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed name
docs/score_tools/gtest.rst
Outdated
Inputs: Software sources (C++), Gtest-based test files (C++) | ||
Outputs: Test binary, Test report (txt, json, xml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting? Was it supposed to render to new lines? If yes, start each line with |
https://rest-sphinx-memo.readthedocs.io/en/latest/ReST.html#line-blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new lines.
docs/score_tools/gtest.rst
Outdated
.. doc_tool:: gtest | ||
:id: doc_tool__gtest | ||
:status: draft | ||
:version: v1.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent in this document once it is v1.15.0
and once 1.15.0
.
Google uses tag with "v" but in bazel registry we use bare number. I would stick to one name here, without "v".
|
||
Integration | ||
~~~~~~~~~~~ | ||
Integrated in bazel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a good idea to add some sample code block with example how to use it in MODULE.bazel?
bazel_dep(name = "googletest", version = "1.15.0")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added sample as suggested.
docs/score_tools/gtest.rst
Outdated
- Further additional safety measure required? | ||
- Confidence (automatic calculation) | ||
* - 1 | ||
- Run tests and generated test report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also use present simple for whole column Use case Description
to match content of the rest of the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Now:
Run tests and generate test report
@PiotrKorkus, fixed the changes. Could you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it lgtm
Added safety evaluation draft of gtest