-
Notifications
You must be signed in to change notification settings - Fork 62
Split JSON-Library in two components #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
< 8000 div class="pull-discussion-timeline js-pull-discussion-timeline js-quote-selection-container js-review-state-classes" data-quote-markdown=".js-comment-body" data-discussion-hovercards-enabled data-issue-and-pr-hovercards-enabled data-team-hovercards-enabled data-hpc >
The created documentation from the pull request is available at: docu-html |
Resolves: #1432
832cb66
to
f78af61
Compare
@aschemmel-tech, What is the folder structure for two subcomponents: the wrapper and the nlohmann_json? Do we need to split the requirements.rst document into two documents? |
:status: valid | ||
:included_by: logic_arc_int__baselibs__json | ||
|
||
.. logic_arc_int_op:: Dump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. logic_arc_int_op:: Dump | |
.. logic_arc_int_op:: Write |
to be consistent with the naming in https://github.com/eclipse-score/baselibs/blob/main/score/json/i_json_writer.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
@aschemmel-tech, thank you. See also the discussion about the |
e9a0c93
to
eeb1e5b
Compare
removed/merged the validation requirement as requested in the meeting |
Resolves: #1432