Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2024-11-18] Manual Dependency Bump #18932

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[2024-11-18] Manual Dependency Bump #18932

wants to merge 5 commits into from
+96 −90

Conversation

ArkaSaha30
Copy link
Contributor
@ArkaSaha30 ArkaSaha30 commented Nov 21, 2024 •
edited
Loading

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Dependabot raised the following PRs:

Bumped:

Purely Indirect:

@ArkaSaha30
dependency: bump golang.org/x/crypto from 0.28.0 to 0.29.0
6b8198e 
This commit will bump dependency golang.org/x/crypto from 0.28.0 to 0.29.0

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ArkaSaha30
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.g…
f8cfb43 
…olang.org/grpc/otelgrpc from 0.56.0 to 0.57.0

This commit will bump dependency go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.56.0 to 0.57.0

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ArkaSaha30
dependency: bump golang.org/x/net from 0.30.0 to 0.31.0
8f21530 
dependency: bump golang.org/x/net from 0.30.0 to 0.31.0

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ArkaSaha30
dependency: bump google.golang.org/protobuf from 1.35.1 to 1.35.2
880d5ad 
This commit will bump dependency google.golang.org/protobuf from 1.35.1 to 1.35.2

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@codecov-commenter
Copy link
codecov-commenter commented Nov 21, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.70%. Comparing base (4186283) to head (5339444).
Report is 4 commits behind head on main.

❗ Current head 5339444 differs from pull request most recent head 9c82a17

Please upload reports for the commit 9c82a17 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18932      +/-   ##
==========================================
+ Coverage   68.65%   68.70%   +0.04%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
+ Hits        24413    24429      +16     
+ Misses       9715     9700      -15     
+ Partials     1430     1429       -1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4186283...9c82a17. Read the comment docs.

---- 🚨 Try these New Features:

@ArkaSaha30
Copy link
Contributor Author

/retest-required

@ArkaSaha30
Fix genproto annotations
9c82a17 
* Please add etcd_version annotation in *.proto file with next etcd version
* Run ./scripts/genproto.sh
push_pin
* Run ./scripts/update_proto_annotations.sh

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ArkaSaha30
Copy link
Contributor Author

/retest-required

ahrtr
ahrtr approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member
@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ArkaSaha30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@henrybear327 henrybear327 Awaiting requested review from henrybear327

Assignees
No one assigned
Labels
approved area/clientv3 area/etcdctl area/etcdutl area/testing area/tooling size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArkaSaha30 @codecov-commenter @k8s-ci-robot @ahrtr