Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustness kubernetes compaction #18773

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Robustness kubernetes compaction #18773

wants to merge 11 commits into from

Conversation

serathius
Copy link
Member

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius force-pushed the robustness-kubernetes-compaction branch from af405af to 16221d5 Compare October 23, 2024 21:19
@codecov-commenter
Copy link
codecov-commenter commented Oct 23, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.64%. Comparing base (cfdd69f) to head (6ef84d6).
Report is 2 commits behind head on main.

❗ Current head 6ef84d6 differs from pull request most recent head 606f9c1

Please upload reports for the commit 606f9c1 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18773      +/-   ##
==========================================
- Coverage   68.68%   68.64%   -0.05%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
- Hits        24424    24408      -16     
- Misses       9704     9721      +17     
+ Partials     1430     1429       -1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfdd69f...606f9c1. Read the comment docs.

@serathius serathius force-pushed the robustness-kubernetes-compaction branch from 16221d5 to af405af Compare October 23, 2024 21:47
@serathius
Unify operation refereces by using keyValue as key for put operation
fc84b8a 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Use int for value stored in precomputed maps
430741e 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Refactor watch response util functions for unit tests
4c2bd31 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Extract isUniqueOps function
6d00e7b 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Count number of client puts and don't patch duplicated puts
3ac6fe2 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Use persisted request count to determine if request was persisted
8c5efe0 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Reorder returnTime functions
3ed0f70 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Unify functions for calculating return time
53cb02e 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Use client put count for uniqness
8f4ad32 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Allow duplicated put requests
96c47e8 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Implement Kubernetes like compaction
606f9c1 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius force-pushed the robustness-kubernetes-compaction branch from af405af to 606f9c1 Compare November 17, 2024 09:34
@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved area/robustness-testing area/testing do-not-merge/work-in-progress needs-rebase size/XL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @k8s-ci-robot @codecov-commenter