This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Fixed issue #620 #621
Merged
Fixed issue #620 #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Produce a useful error message if the path of a project file is incorrect in tye.yaml.
- Added a test.
* Produce a useful error message if the path of a project file is incorrect in tye.yaml. * Added a test.
|
Here is a small fix for issue #620 including a test. I humbly hope you find it useful. |
|
Hmm .. I'm not sure why the Ubuntu build fails now. In the build logs there is this message about an ArgumentOutOfRangeException. I'll investigate this later. |
…ution. Moved directory check one level higher from EnsureMSBuildRegistered() to the caller ReadProjectDetailsAsync(). This means that this code is always executed. In EnsureMSBuildRegistered() it was only executed once per proces because of the static field "registered". The placement of the check after evaluation of the the field "registered" was the reason why the test WrongProjectPathProducesCorrectErrorMessage worked when executed alone but not when any other test that called EnsureMSBuildRegistered() was executed before. With this change the directory check is always executed now, even if the EnsureMSBuildRegistered() was already executed successfully. But the performance impact should not be significant while the type of generated error message is more deterministic and not dependent on execution order.
|
It looks like my code change and test seem to work stable now but in the Ubuntu CI build there was an error in an unrelated test named MultiRepo_Works showing a network connection problem. Could this be a transient infrastructure problem? |
|
Re-running the tests had them all pass. @jkotalik have you noticed these being flaky in the past? |
|
Hi guys! Any news on this? |
JunTaoLuo
approved these changes
Aug 19, 2020
|
Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.