This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Use BufReader and BufWriter more 🤦
#185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For example, compiling just the entrypoint of https://github.com/ditto-lang/todomvc/tree/9e72ba23fc0a8ecfb584ce6bc05afd3c6630210a Before: After: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flamegraphs from #183 showed that
ditto makewas spending a significant amount of time serializing and deserializing.Making this change gives a big speedup, so I'm pretty sure that was the problem. Although switching to something like
bincodecould also be worthwhile? #184Typechecking modules is now the bottleneck, which is what I'd expect.