Raise dependency file content not changed error when requirements are unchanged #13336
Conversation
…ishekbhaskar/fix-sentry-no-change-error
npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/pnpm_workspace_updater.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I'm concerned about suppressing this error from Sentry. When NoChangeError is raised, it means our detection logic determined an update was available but then our file updater couldn't actually apply any changes. That's a failure in our updater that we need visibility into
…ishekbhaskar/fix-sentry-no-change-error
|
I've retained the |
I agree with @robaiken. Our purpose is not trying to get rid of sentry errors. No change error is error we always need. The main issue we should solve errors that are causing no change error one by one. Why did we even started update if there was no change. This is the question should be answered for each ecosystem seperatelly. |
If requirements didn't change why did we start the update process. We should solve this approach. I mean lets assume Lets check that with an example. We have a package version 1.2.3 and we have requirement <=1.2.3. Event the dependency has 1.2.4 and because requirement is asking <=1.2.3, in that case we already have max version. Then we shouldn't start update process. Let me know if I am missunderstanding |
What are you trying to accomplish?
This PR adds a new
NoFilesUpdatedErrorerror type inerrors.rb. This is imported in the npm file_updater class to check if the dependencies need an update and if they do not, it displays this error.This error occurs most likely when the lockfile is out of sync but the catalogue is already correct with the latest dependency versions. This error displays a message to the user to regenerate the lockfile.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist