Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for named sequences (closes #43) #45

Merged
merged 13 commits into from
Oct 16, 2022
Merged

add support for named sequences (closes #43) #45

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
589dc4c
WIP: initial support for sequences
delan Apr 3, 2022
9edcd69
Display: refactor references to $display-font
delan Apr 3, 2022
822222a
Display: correctly handle emoji presentation in sequences
delan Apr 3, 2022
28660af
clean up biggest rough edges around sequence ui
delan Apr 3, 2022
42aee8c
squelch react key warnings in Display + SequenceDetails
delan Apr 4, 2022
f292791
merge from master
delan Apr 4, 2022
75f5afb
merge from master
delan Oct 16, 2022
713d7a4
data: add tables of sequences and their points and names
delan Oct 16, 2022
abd4301
Detail: show first sequence name if any
delan Oct 16, 2022
7ab78b1
search: make searchBySequence search known named sequences
delan Oct 16, 2022
5897dba
search: add support for searching by names of sequences
delan Oct 16, 2022
ce32ebc
data: add named sequences from NamedSequences.txt
delan Oct 16, 2022
beec78a
SearchResultRow: use ellipsis with sequences for mobile readability
delan Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up biggest rough edges around sequence ui
  • Loading branch information
@delan
delan committed Apr 3, 2022
commit 28660af82ed91ef16b4510be645f5dc8a7d0cc5b
17 changes: 11 additions & 6 deletions src/new.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {
getAliasValue,
getNameProperty,
getString,
isEmoji,
isEmojiPresentation,
} from "./data";
import { pointsToString } from "./encoding";
Expand Down Expand Up @@ -148,7 +149,7 @@ function Detail({ search }: { search: () => void }) {
<a href={toFragment(points)} >
{ifSequence(
points,
(_) => "FIXME",
(_) => "(sequence)",
(x) => pointToName(data, x),
)}
</a>
Expand All @@ -168,6 +169,7 @@ function Detail({ search }: { search: () => void }) {

function PointDetails({ point }: { point: number }) {
const data = useContext(DataContext)!;
const emoji = isEmoji(data, point);

return (
<>
Expand All @@ -185,10 +187,13 @@ function PointDetails({ point }: { point: number }) {
<StringPair field="hjsn" label="Hangul Jamo short name" />
<StringPair field="uhdef" label="Unihan kDefinition" />
<StringPair field="uhman" label="Unihan kMandarin" />
<dt className="compact">Emoji_Presentation</dt>
<dd className="compact">
{isEmojiPresentation(data, point) ? "Yes" : "No"}
</dd>
{emoji && <dt>Emoji properties</dt>}
{emoji && (
<dd>
Emoji_Presentation?{" "}
{isEmojiPresentation(data, point) ? <>Yes</> : <strong>No</strong>}
</dd>
)}
</dl>
</>
);
Expand Down Expand Up @@ -401,7 +406,7 @@ function SearchResultLabel({
<>
{pointsToYouPlus(points)}
{space}
{`FIXME`}
{`(sequence)`}
</>
);
case "name":
Expand Down