Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Danger on this repo #1500

Closed

Conversation

manicmaniac
Copy link
Member
@manicmaniac manicmaniac commented Sep 29, 2024

https://github.com/danger/danger/blob/cb381b813d0199d415a365fcb36ef7a4b66ed25c/.github/workflows/CI.yml enabled running Danger. But the next commit https://github.com/danger/danger/blob/7da261774d02359b723aec83abc3ba72fe7e8149/.github/workflows/CI.yml disabled it by adding echo before the danger command.

I don't know the reason but I think it is useful to run Danger on this repo.

@manicmaniac manicmaniac self-assigned this Sep 29, 2024
@manicmaniac manicmaniac force-pushed the run-danger-on-this-repo branch 2 times, most recently from b334086 to 8d34364 Compare September 29, 2024 07:23
https://github.com/danger/danger/blob/cb381b813d0199d415a365fcb36ef7a4b66ed25c/.github/workflows/CI.yml enabled running Danger.
But the next commit https://github.com/danger/danger/blob/7da261774d02359b723aec83abc3ba72fe7e8149/.github/workflows/CI.yml disabled it by adding `echo` before the danger command.

I don't know the reason but I think it is useful to run Danger on this repo.
@manicmaniac manicmaniac force-pushed the run-danger-on-this-repo branch from 8d34364 to 4491449 Compare September 29, 2024 07:26

danger:
runs-on: ubuntu-latest
permissions:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token#changing-the-permissions-in-a-forked-repository

You can use the permissions key to add and remove read permissions for forked repositories, but typically you can't grant write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant