Bugfix for Image fields when using a non-default connection #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt Post's connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image fields only used the default connection when loading rather than using parent Post's connection. I noticed that for all fields there is a
postMetathat is set to use the same connection as the parent, so the Image field has been changed to use this instead of using the basePostMetamacro methods.In order to test this I've had to create a new connection in
tests/config/bootstrap.php, and also make a fixture class intests/CorcelIntegrationTest.php. I would have put it in its own file, but the tests themselves aren't loaded via PSR-4. I thought it would be simpler to add the class inline for the time being, as its a wider change to load them all this way.