make root-test: support TESTFLAGS="-tags=no_btrfs" #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now btrfs test can be skipped by setting TESTFLAGS="-tags=no_btrfs" Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
3d8343d to
3ec07a7
Compare
AkihiroSuda
commented
Jun 13, 2017
| @@ -0,0 +1,3 @@ | |||
| // +build !linux no_btrfs | |||
There was a problem hiding this comment.
Note: without this file, make root-test fails:
can't load package: package github.com/containerd/containerd/snapshot/btrfs: n
o buildable Go sourcefiles in /home/suda/gopath/src/github.com/containerd/cont
ainerd/snapshot/btrfs
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
=======================================
Coverage 59.05% 59.05%
=======================================
Files 5 5
Lines 779 779
=======================================
Hits 460 460
Misses 205 205
Partials 114 114
Continue to review full report at Codecov.
|
| @@ -1,4 +1,4 @@ | |||
| // +build linux | |||
| // +build linux,!no_btrfs | |||
There was a problem hiding this comment.
All you need is this change to prevent tests from running. Why did you change the other two places? We don't want to sub out an entire package, just the import that we are already doing in the containerd.main
|
ok, instead, we should make target pkgs for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now btrfs test can be skipped by setting TESTFLAGS="-tags=no_btrfs"
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp