Nothing Special   »   [go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub actions release workflow set output #7581

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Update GitHub actions release workflow set output #7581

merged 1 commit into from
Oct 25, 2022

Conversation

austinvazquez
Copy link
Member
@austinvazquez austinvazquez commented Oct 24, 2022 •
edited
Loading

Migrate from set-output call to write to new GITHUB_OUTPUT environment file.

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Resolves #7580

Signed-off-by: Austin Vazquez macedonv@amazon.com

@k8s-ci-robot
Copy link

Hi @austinvazquez. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@austinvazquez
Migrate away from GitHub actions set-output
be3987a 
Migrate from set-output call to write to new GITHUB_OUTPUT environment
file.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez force-pushed the upgrade-release-workflow branch from 8a36208 to be3987a Compare October 24, 2022 22:50
@austinvazquez
Copy link
Member Author

Included changes to windows-periodic.yml workflow set-output references since the scope was pretty limited. Found no references to save-state.

@austinvazquez austinvazquez marked this pull request as ready for review October 25, 2022 01:56
@kzys
Copy link
Member
kzys commented Oct 25, 2022

/ok-to-test

@kzys kzys merged commit 7062dbc into containerd:main Oct 25, 2022
@austinvazquez austinvazquez deleted the upgrade-release-workflow branch October 25, 2022 17:18
@aznashwan aznashwan mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxpv mxpv mxpv approved these changes

@kzys kzys kzys approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update release action for set-output deprecation
4 participants
@austinvazquez @k8s-ci-robot @kzys @mxpv