-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix install cni script #7484
fix install cni script #7484
Conversation
Hi @lengrongfu. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
77f3afd
to
15fafc2
Compare
How do you feel about using
Documentation (
|
First contact with GOMOD, but it feels very useful in the project. |
1fd096c
to
883ad75
Compare
883ad75
to
7666be6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look no good
a6a4bb9
to
ecab41e
Compare
ecab41e
to
0074f2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, but otherwise looks good to me
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
0074f2f
to
047e684
Compare
@fuweid @thaJeztah Can you again review this PR? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace the source of the read value, from
"$GOPATH"/src/github.com/containerd/containerd/go.mod
changing togo.mod
or../../go.mod
.issue: #7472