Nothing Special   »   [go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix install cni script #7484

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

lengrongfu
Copy link
Contributor

Replace the source of the read value, from "$GOPATH"/src/github.com/containerd/containerd/go.mod changing to go.mod or ../../go.mod.

issue: #7472

@k8s-ci-robot
Copy link

Hi @lengrongfu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lengrongfu lengrongfu force-pushed the feat/update_install_cni_script branch from 77f3afd to 15fafc2 Compare October 6, 2022 08:16
@mxpv
Copy link
Member
mxpv commented Oct 6, 2022

How do you feel about using GOMOD env instead?

$ pwd
/Users/mxpv/Github/containerd/script/setup

$ go env | grep GOMOD
GOMOD="/Users/mxpv/Github/containerd/go.mod"

Documentation (go help environment):

GOMOD
The absolute path to the go.mod of the main module.
If module-aware mode is enabled, but there is no go.mod, GOMOD will be
os.DevNull ("/dev/null" on Unix-like systems, "NUL" on Windows).
If module-aware mode is disabled, GOMOD will be the empty string.

script/setup/install-cni Outdated Show resolved Hide resolved
@lengrongfu
Copy link
Contributor Author

How do you feel about using GOMOD env instead?

$ pwd
/Users/mxpv/Github/containerd/script/setup

$ go env | grep GOMOD
GOMOD="/Users/mxpv/Github/containerd/go.mod"

Documentation (go help environment):

GOMOD
The absolute path to the go.mod of the main module.
If module-aware mode is enabled, but there is no go.mod, GOMOD will be
os.DevNull ("/dev/null" on Unix-like systems, "NUL" on Windows).
If module-aware mode is disabled, GOMOD will be the empty string.

First contact with GOMOD, but it feels very useful in the project.

@lengrongfu lengrongfu force-pushed the feat/update_install_cni_script branch 4 times, most recently from 1fd096c to 883ad75 Compare October 7, 2022 16:14
script/setup/install-cni Outdated Show resolved Hide resolved
script/setup/install-cni Outdated Show resolved Hide resolved
script/setup/install-cni Outdated Show resolved Hide resolved
@lengrongfu lengrongfu force-pushed the feat/update_install_cni_script branch from 883ad75 to 7666be6 Compare October 8, 2022 01:46
Copy link
Member
@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look no good

script/setup/install-cni Outdated Show resolved Hide resolved
@lengrongfu lengrongfu force-pushed the feat/update_install_cni_script branch 4 times, most recently from a6a4bb9 to ecab41e Compare October 8, 2022 07:32
script/setup/install-cni Outdated Show resolved Hide resolved
@lengrongfu lengrongfu force-pushed the feat/update_install_cni_script branch from ecab41e to 0074f2f Compare October 8, 2022 14:50
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but otherwise looks good to me

Vagrantfile Show resolved Hide resolved
script/setup/install-cni Outdated Show resolved Hide resolved
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
@lengrongfu lengrongfu force-pushed the feat/update_install_cni_script branch from 0074f2f to 047e684 Compare October 10, 2022 02:29
@lengrongfu
Copy link
Contributor Author

@fuweid @thaJeztah Can you again review this PR? thanks!

Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 30ae238 into containerd:main Oct 19, 2022
@thaJeztah thaJeztah added the cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants