[release/1.2 backport] Fix CI due to Golang 1.10.6 / 1.11.3 regressions (workaround) #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix CI is failing due to a regression in Go 1.10.6 / 1.11.3 (see golang/go#29241) ``` package github.com/containernetworking/plugins/...: github.com/containernetworking/plugins/...: invalid import path: malformed import path "github.com/containernetworking/plugins/...": double dot ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 52de371) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @crosbymichael @andrewhsu @estesp PTAL |
|
looks like something failed on the appveyor build: even though the pr to master had all green |
|
Interesting. Can't see the full output from my phone, but can have a look when I'm at my computer |
Missed that you posted a link 😅 Looks like that's the failure ? Could be a flaky not sure. Don't suspect it's related to my changes |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #2881 +/- ##
===============================================
- Coverage 47.41% 43.74% -3.68%
===============================================
Files 91 100 +9
Lines 8410 10728 +2318
===============================================
+ Hits 3988 4693 +705
- Misses 3699 5305 +1606
- Partials 723 730 +7
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2879 for the 1.2 release branch
Attempt to fix CI is failing due to a regression in Go 1.10.6 / 1.11.3 (see golang/go#29241)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit 52de371)
Signed-off-by: Sebastiaan van Stijn github@gone.nl