type_url set correctly from container structure. #1091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
=======================================
Coverage 54.51% 54.51%
=======================================
Files 16 16
Lines 1229 1229
=======================================
Hits 670 670
Misses 386 386
Partials 173 173Continue to review full report at Codecov.
|
mlaventure
reviewed
Jun 26, 2017
services/containers/helpers.go
Outdated
| @@ -12,6 +12,11 @@ import ( | |||
| "google.golang.org/grpc/codes" | |||
| ) | |||
|
|
|||
| const ( | |||
| //URLTypePrefix adds prefix to make OCI spec version as per protobuf's TypeUrl | |||
| URLTypePrefix = "types.containerd.io/opencontainers/runtime-spec/" | |||
There was a problem hiding this comment.
Wouldn't it be io.containerd.types/?
|
the event package is using `types.containerd.io` atm (cc @stevvoe, I
believe that's what google documentation recommends, as it needs to be an
URL you can navigate to from a web-browser)
On Mon, Jun 26, 2017 at 2:01 PM Michael Crosby ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In services/containers/helpers.go
<#1091 (comment)>
:
> @@ -12,6 +12,11 @@ import (
"google.golang.org/grpc/codes"
)
+const (
+ //URLTypePrefix adds prefix to make OCI spec version as per protobuf's TypeUrl
+ URLTypePrefix = "types.containerd.io/opencontainers/runtime-spec/"
Wouldn't it be io.containerd.types/?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1091 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APUifkUyr_qb0I8VxAk50r14jAViVwC3ks5sIBwKgaJpZM4OE5Ic>
.
--
Sent from my phone.
|
c2f9870 to
3b7d1eb
Compare
|
Updated with suggested changes. //cc @mlaventure |
Fixes containerd#1052 Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
|
Does #1133 more completely handle this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1052
This fix, sets the
type_urlcorrectly, while reading information fromcontainer, without storing changes incontainerstruct.Signed-off-by: Kunal Kushwaha kushwaha_kunal_v7@lab.ntt.co.jp