build: replace add_compile_definitions
#321
Conversation
Replace `add_compile_definitions` with `add_compile_options` since the former was introduced in 3.12.
|
@jgm sorry about the compatibility issue, this should fix that. |
|
Thank you! |
|
@compnerd I've been seeing this build failure on our fuzzing setup; I don't know if it has to do with your changes, but they're the most recent changes to the build infrastructure. Also paging @nwellnhof https://oss-fuzz-build-logs.storage.googleapis.com/log-0d4dbbcd-58ba-4341-9359-708e4381d3df.txt The error is Is it possible that one of the changes you made broke this? |
|
I think its probably related ... Note that it is trying to link against I don't immediately see where this command is coming from: |
|
No, it was |
Replace
add_compile_definitionswithadd_compile_optionssince theformer was introduced in 3.12.