fix: centralize warning message in static error #20389
Open
+175
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
Oct 20, 2025
| </div> | ||
| </body> | ||
|
|
||
| <head> |
There was a problem hiding this comment.
the prettier code style is that <head> and <body> both should be indented
|
|
||
| p, | ||
| li { | ||
| color: rgb(161, 161, 170); |
There was a problem hiding this comment.
this should still be a hex color
| p, | ||
| li { | ||
| color: rgb(161, 161, 170); | ||
| line-height: 22.4px; |
There was a problem hiding this comment.
22.4px is a specific enough value to deserve a rationale comment. why not a percent anymore? why not 22px?
| padding-top: 10px; | ||
| margin-left: 30px; | ||
| font-size: 14px; | ||
| line-height: 25.6px; |
There was a problem hiding this comment.
another very odd line-height choice
| } | ||
|
|
||
| .warning li { | ||
| text-align: left; |
There was a problem hiding this comment.
where is the center align coming from? manually left aligning things that should just be left aligned feels like a bit of a bandaid
| background: rgb(13, 19, 33); | ||
| width: 100%; | ||
| padding: 24px; | ||
| text-align: left; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Fixes #20369