refactor: clean up policy.rego #20366
Open
+377
−268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some of the naming and organization of this file to be really confusing/overwhelming at first. I'm hoping that by rearranging a couple of things, renaming some variables, and rewriting some comments that I can make it less intimidating for the next person who needs to dive in to this policy. 😄
This is all a bunch of stuff I wanted to do while adding the org member level, but I felt like it cluttered the diff too much, making it unclear what was just being shuffled around vs what was actually meaningfully changing. Once this is merged, the org member code should slot in very nicely, with a much smaller diff.
This whole PR should essentially be a no-op! Anything that looks like it's changing behavior is unintentional. This change is meant to be purely for the benefit of future readers.